quickwit-oss / quickwit-oss/quickwit

Fix bad pattern used in CLI argument parsing

Open
#881 1 comment 0 reactions 1 assignee View on GitHub

@fmassot is already working on this.

Since Mar 29, 2022.

backlog enhancement good first issue low-priority
Dominant language
Rust
Stars
11.7k
Forks
597
Avg merge
2d 22h
Merged PRs (30d)
37

Description

As suggested by @guilload

Would be better to use this pattern:

let metastore_uri = matches
    .value_of("metastore-uri")
    .map(normalize_uri)
    .expect("`metastore-uri` should be a required arg.")?;

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.