quickwit-oss / quickwit-oss/quickwit

`IndexingSplitStore` copies local files that could be moved

Open
#6,447 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
11.7k
Forks
597
Avg merge
2d 22h
Merged PRs (30d)
37

Description

Splits are staged on local fs before being uploaded. When the index dir targets the same file://... fs, splits can simply be moved. However, the IndexingSplitStore copies them. The Uploader calls IndexingSplitStore::store_split which in turn calls Storage::put. For LocalFileStorage, put is implemented as a copy.

Low priority because production deployments use object storage, but nice to fix.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Uploader call to IndexingSplitStore::store_split, then trace Storage::put and LocalFileStorage::put. Check how file:// index and staging files are handled, and verify that same-filesystem splits are moved rather than copied without changing object-storage behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend, infrastructure
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.