quickwit-oss / quickwit-oss/quickwit

rollback of metastore is far from perfect

Open
#5,052 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
11.7k
Forks
597
Avg merge
2d 22h
Merged PRs (30d)
37

Description

rolling back the metastore is currently not guaranteed to work well:

  • assuming the postgresql metastore, we have migrations, which handles column creation/deletion. However if new fields are added in one of the stored json, an old quickwit might not be able to read the content of the metastore (we forbid unknown fields in many places).
  • assuming a file based metastore, we don't even have a notion of rollback, except for backing up the metastore files, and restoring them

we should figure out how to make this better. The solution would likely be something along the line of:

  • for postgresql: add code in the down migrations to remove the unwanted fields stored inside json (and document the rollback process)
  • for other metastore, provide some tool to convert newer metastore files into older ones, and document how to use them to rollback an existing cluster

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by mapping the PostgreSQL down migrations and the file-based metastore behavior described in the issue. Define the rollback process for both metastore types, including JSON-field compatibility, conversion or restoration steps, and documentation that explains how to roll back an existing cluster.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql, rust
Domain
backend, databases
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.