quickwit-oss / quickwit-oss/quickwit
Remove use of FnvHashMap/Set for queue IDs and client IDs
Open
Nobody has claimed this yet.
enhancement
low-priority
- Dominant language
- Rust
- Stars
- 11.7k
- Forks
- 597
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 37
Description
It's only good for really short strings (< 20 bytes), but our strings are not that short:
- node IDs are not that short:
quickwit-indexer-prod-us-east-1a - index UIDs are not that short:
logline.c06d8f1aee.2024-02-01.10:01HNGZE70MS3YBV8FVSMVTA910 - queue IDs are not that short:
<index_uid>/<source_id>/<shard_uid>
Let's revert to the default HashMap/Set.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for FnvHashMap and FnvHashSet uses associated with queue IDs, client IDs, node IDs, or index UIDs. Replace the relevant collections with the default HashMap and Set, then run the affected Rust tests or checks to confirm behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, performance
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100