quickwit-oss / quickwit-oss/quickwit
Panic in the local split store
Open
Nobody has claimed this yet.
bug
- Dominant language
- Rust
- Stars
- 11.7k
- Forks
- 597
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 37
Description
This is the log reported by @tuziben
'tokio-runtime-worker' panicked at 'No remaining split to remove', quickwit-indexing/src/split_store/local_split_store.rs:199:18
The line is here.
An error in the move_out function at this step could unsync the split_folders and split_ids binary heap, thus leading to the panic.
We could refactor the code to avoid this effect and protect us against this panic.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in quickwit-indexing/src/split_store/local_split_store.rs, reading move_out around line 178 and the panic at line 199. Trace how an error there could leave split_folders and split_ids out of sync. Done means the refactoring prevents that inconsistency and the reported "No remaining split to remove" panic.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100