quickwit-oss / quickwit-oss/quickwit
Refactor the metastore factory cache.
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Rust
- Stars
- 11.7k
- Forks
- 597
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 37
Description
Two things to improve:
- Remove the code redundancy between the postgresql metastore factory and the file metastore factory.
- Cache only one metastore instance inside the metastore factory cache as suggested in this discussion. Caution: this will trigger some test failures, we need to fix them.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the factory implementations in quickwit/quickwit-metastore/src/metastore/postgresql_metastore.rs and quickwit/quickwit-metastore/src/metastore/file_backed_metastore/file_backed_metastore_factory.rs, then read the linked discussion for the cache behavior. Refactor the redundant code and ensure the metastore factory cache holds only one instance. Run the affected tests and fix the failures caused by this change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100