quickwit-oss / quickwit-oss/quickwit
Change splits filter for timestamp fields to use `OffsetDateTime` rather than unix timestamps.
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 11.7k
- Forks
- 597
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 37
Description
Currently, we use unix timestamps for a lot of places where we're actually handling datetimes. This would be fine except in a lot of cases with tests, the timestamps don't actually change because our accuracy is in seconds and the tests can run in under a second.
I think we should change the filter so that we expect a OffsetDateTime type rather than a UNIX timestamp in seconds to avoid confusion and give us a bit more flexibility in the filter.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the splits filter and the code that currently represents timestamp fields as Unix timestamps in seconds. Trace the related tests, especially cases where timestamps do not change within a second. Done means the filter expects OffsetDateTime and the affected tests cover the more flexible timestamp behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- search
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100