quickwit-oss / quickwit-oss/quickwit

Remove the fastfield codecs dependency in quickwit, and the remove make_fast_field_reader function

Open
#2,221 5 comments 0 reactions 1 assignee View on GitHub

@PSeitz is already working on this.

Since Nov 2, 2022.

enhancement
Dominant language
Rust
Stars
11.7k
Forks
597
Avg merge
2d 22h
Merged PRs (30d)
37

Description

Make FastFieldReaders::typed_fast_field_reader() public in tantivy
and remove make_fast_field_reader in quickwit, and remove the fastfield code dependency

But first make sure this is safe and this is really doing thing we want.
Most notably do we always use it with the right type or not?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.