quickwit-oss / quickwit-oss/quickwit

U64 as displayed in the UI are wrong.

Open
#2,013 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
11.7k
Forks
597
Avg merge
2d 22h
Merged PRs (30d)
37

Description

As spotted in #2011.

U64 field are very nice for users indexing ids.
They can be a nicer solution than strings, for instance if we do grouping and the number of distinct values does not justify dicitonary encoding.

Javascript will deserialize their JSON value as a javascript Number, which has a limited precision.
The number as displayed in the UI will hence be erroneous.

This limitation is not really a JSON issue (AFAIK JSON does not
restrict the range of integer values), but is shared by many other programming language.

I am not entirely sure what we should do here tbh. :)

We also probably support string as an input for u64.

On serialize, a common solution to this problem is to add a string version of int fields.

"id": 23423432432424324,
"id_str": "23423432432424324"

But then we could have some collision problems.
We could add a serialization option to serializes all ints as a string.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the U64 JSON serialization and the UI deserialization behavior described here, then compare the related discussion in issue #2011. Clarify whether string input is supported and which serialization representation should be authoritative. Done means the chosen approach preserves full U64 values in the UI without collisions.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, rust
Domain
api, frontend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.