quickwit-oss / quickwit-oss/quickwit
Use NonZeroUsize in Stamper and maybe somewhere else.
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Rust
- Stars
- 11.7k
- Forks
- 597
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 37
Description
PR #1916 introduced a stamper that always returns a non zero integer.
We can use here NonZeroUsize.
Quoting @fulmicoton in https://github.com/quickwit-oss/quickwit/pull/1916#discussion_r966883799
Maybe working with a NonZeroUsize here, and in some other places WHERE it is not annoying.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Stamper introduced in PR #1916 and inspect where it returns an integer that is always nonzero. Check nearby uses for other suitable NonZeroUsize conversions; done means the appropriate cases use NonZeroUsize without making the surrounding code awkward.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100