quickwit-oss / quickwit-oss/quickwit
Refactoring needed in the tag extraction code.
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 11.7k
- Forks
- 597
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 37
Description
The extraction of tags for https://github.com/quickwit-oss/quickwit/pull/1634 highlighted a limitation in the way we manipulated queries.
The extraction of tags (extract_tags_from_query) operates on the UserInputAst, which is schema independent, and therefore, untyped.
This made it impossible for us to have support for user queries such as my_bool_tag_field:1, as tag pruning would translate into searching for the tag my_bool_tag_field:1 instead of my_bool_tag_field:true.
We need to:
a) Either change the code that extracts tags
b) Put that logic downstream, in the part that interprets the tag AST.
I suspect the change is deeper than might seem at first sight.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at extract_tags_from_query and trace how UserInputAst is interpreted for typed fields. Reproduce the my_bool_tag_field:1 case and follow the tag-pruning path; done means boolean tag queries are interpreted with the correct typed value rather than retaining the numeric literal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- search
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100