quickwit-oss / quickwit-oss/quickwit
Add to code style: when to pass reference or move
Open
@PSeitz is already working on this.
Since Feb 7, 2022.
dev-doc
enhancement
- Dominant language
- Rust
- Stars
- 11.7k
- Forks
- 597
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 37
Description
add an item about when to pass reference or move, iterator or collection.
TLDR:
If only the reference is used, pass a reference.
More importantly: if the object is used, move. It can sometime help avoid a clone.
Same logic for iterator vs collection
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.