queryverse / queryverse/Query.jl
`@orderby` should throw an error if incorrect column syntax is used
Open
@davidanthoff is already working on this.
Since Nov 14, 2019.
bug
- Dominant language
- Julia
- Stars
- 403
- Forks
- 48
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 6
Description
Using Query.jl in conjunction with DataFrames.jl I find that I often make silly mistakes with the syntax, such as:
df |>
@orderby(:IssueDate) |>
DataFrame
instead of
df |>
@orderby(_.IssueDate) |>
DataFrame
In such cases, Query.jl simply ignores the @orderby line, and does so silently.
I think that if the arguments to @orderby do not resolve to something in df that can be ordered, there should be a warning thrown, if not an error.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.