queryverse / queryverse/ElectronDisplay.jl

Color is rendered incorrectly if it is passed via `datum`.

Open
#83 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
CSS
Stars
89
Forks
17
Avg merge
19h 47m
Merged PRs (30d)
5

Description

On the current master, the color is rendered incorrectly if it is set via the datum property.

The bug can be reproduced using the following code:

using VegaLite: @vlplot
@vlplot() + @vlplot(mark = :point, x = rand(10), y = rand(10), color = {datum = "class 1"}) + @vlplot(mark = :point, x = rand(10), y = rand(10), color = {datum = "class 2"})

In Firefox and Chromium, this renders correctly as:

image

When using ElectronDisplay with the current master (e421241) the color channel is ignored:
image

Edit: This used to work with v0.8.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the provided @vlplot reproduction using ElectronDisplay, comparing its output with Firefox or Chromium and the v0.8 behavior. Trace how the color channel is handled for datum values in the ElectronDisplay rendering path. Done means the two point layers render their distinct datum colors correctly in ElectronDisplay.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, julia
Domain
data-visualization, desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.