queryverse / queryverse/DataValues.jl

remove convert method for `Any`?

Open
#51 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
14
Forks
6
Avg merge
1d 7h
Merged PRs (30d)
2

Description

As in https://github.com/JuliaData/CategoricalArrays.jl/issues/177, the method

Base.convert(::Type{Any}, ::DataValue{Union{}}) = NA

causes a lot of recompilation. IIUC, NA is a singleton and so this method is not different from the default conversion to Any in Base?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the Base.convert behavior for Any and the linked CategoricalArrays.jl issue, then inspect the implementation of Base.convert(::Type{Any}, ::DataValue{Union{}}). Done means establishing whether removing this method preserves the NA singleton behavior while avoiding the reported recompilation.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.