quarto-dev / quarto-dev/quarto

Wrong background makes equation preview invisible

Open
#945 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug vscode
Dominant language
TypeScript
Stars
645
Forks
62
Avg merge
17h 42m
Merged PRs (30d)
13

Description

Bug description

AFAICS recently VSCode stopped writing themes to settings.json and started saving them as part of the workspace state. This seems to confuse the quarto:equation preview panel, which now renders equations white on white when a light theme is active. One workaround is to explicitly set "workbench.colorTheme": "VS Code Light" in settings.json.

PS: while I was testing this I ran into https://github.com/quarto-dev/quarto/issues/703 again. Please give it a look, I provided an easy grammar fix.

Steps to reproduce
  • Create qmd file
  • Write $x^2$
  • Position cursor inside the equation
  • Open the quarto:equation preview
Image
  • Add "workbench.colorTheme": "VS Code Light" to settings.json
  • Reload window
  • Check again
Image
Actual behavior

Renders equations white on white making them invisible.

Expected behavior

Should render equations white on dark or black on light according to the current theme.

Your environment
  • IDE: VSCode 1.113.0
  • macOS Tahoe

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the quarto:equation preview panel and reproduce the issue in VSCode 1.113.0 using a light theme, then compare theme detection when the theme is stored in workspace state versus settings.json. Done means equations render with suitable contrast: white on dark themes and black on light themes; reload the window and repeat the reproduction steps to verify both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.