quarto-dev / quarto-dev/quarto
Visual Editor: dialogs are not closed with `Cmd + Enter`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 645
- Forks
- 62
- Avg merge
- 17h 42m
- Merged PRs (30d)
- 13
Description
From Hadley:
I noticed that quarto visual editor dialogs (at least link and image editors) don’t respond to cmd + enter, which I expect to close the dialog, in the same say as clicking ok
It would be great if the dialog boxes were closed using the shortcut not only via "click".
Something to investigate on how the webview is created with React components
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the webview is created and how the React components implement the link and image editor dialogs. Reproduce the shortcut issue, then verify that Cmd + Enter closes each dialog in the same way as clicking OK.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100