quarto-dev / quarto-dev/quarto-cli

Improve linting to show that `out-width` and `out-height` are being ignored in revealjs when stretch is activated (globally or per slide)

Open
#9,512 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement lint revealjs
Dominant language
JavaScript
Stars
6k
Forks
458
Avg merge
1d 9h
Merged PRs (30d)
41

Description

Bug description

using out-width and out-height in chunks in revealjs documents appears to be ignored.

Steps to reproduce
---
format: revealjs
---

## out-width: 1000px

```{r}
#| out-width: 1000px
library(ggplot2)

ggplot(mpg, aes(displ, hwy, colour = class)) + 
  geom_point()
```

## out-width: 100px

```{r}
#| out-width: 100px
library(ggplot2)

ggplot(mpg, aes(displ, hwy, colour = class)) + 
  geom_point()
```

Expected behavior

I expected the figure would change the output of the figure files

Actual behavior

they appear unchanged

Screenshot 2024-04-27 at 8 43 33 PM Screenshot 2024-04-27 at 8 43 40 PM
Your environment
  • IDE: RStudio 2023.12.0+359
  • OS: Sonoma 14.4.1 (23E224)
Quarto check output
Quarto 1.4.553
[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.11: OK
      Dart Sass version 1.69.5: OK
      Deno version 1.37.2: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.4.553
      Path: /Applications/quarto/bin

[✓] Checking tools....................OK
      TinyTeX: v2021.12
      Chromium: (not installed)

[✓] Checking LaTeX....................OK
      Using: TinyTex
      Path: /Users/emilhvitfeldt/Library/TinyTeX/bin/universal-darwin
      Version: 2021

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.11.7
      Path: /Users/emilhvitfeldt/.pyenv/versions/3.11.7/bin/python3
      Jupyter: (None)

      Jupyter is not available in this Python installation.
      Install with python3 -m pip install jupyter

[✓] Checking R installation...........OK
      Version: 4.3.3
      Path: /Library/Frameworks/R.framework/Resources
      LibPaths:
        - /Users/emilhvitfeldt/Library/R/arm64/4.3/library
        - /Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/library
      knitr: 1.45
      rmarkdown: 2.26

[✓] Checking Knitr engine render......OK

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reproducing the revealjs document with out-width and out-height while stretch is enabled globally and per slide, then trace the linting entry point that handles these options. Done means lint output clearly warns that the dimensions are ignored in both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, r
Domain
tooling, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.