quarto-dev / quarto-dev/quarto-cli

HTML format: clarify allowed output from filters

Open
#6,281 0 comments 2 reactions 1 assignee View on GitHub

@cscheid is already working on this.

Since Jul 20, 2023.

enhancement html
Dominant language
JavaScript
Stars
6k
Forks
458
Avg merge
1d 9h
Merged PRs (30d)
41

Description

When rendering to HTML formats, if the output generated by Pandoc isn't valid HTML, then our postprocessor can get confused; quarto parses the document to make a number of DOM API calls. The consequences of invalid HTML range from nothing (the DOM parser recovers a valid structure) to corrupted output and crashing.

We should consider validating the HTML prior to running the postprocessors. This would let us give better error messages (to the effect of "something in your filters generated bad HTML"), and would allow us to make stronger statements about what we consider to be bugs in other code vs. ours.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.