quarto-dev / quarto-dev/quarto-cli

[Confluence] Aborting publishing to a public space should end command without an Error

Open
#4,890 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement publishing-confluence
Dominant language
JavaScript
Stars
6k
Forks
458
Avg merge
1d 9h
Merged PRs (30d)
41

Description

Bug description

To reporoduce:

  • quarto create project confluence
  • Publish to a public space
  • On warning about permissions, answer: No

Result: An error (see below)
Expected: Some kind of message that indicates I cancelled publishing, e.g. "Publishing aborted by user"

? Space or Parent Page URL: › https://cwickham.atlassian.net/wiki/spaces/QTS
[✓] Verifying...

 ? We've detected that your account is not able to manage the permissions for this destination.

Published pages will be directly editable within the Confluence web editor.

This means that if you republish the page from Quarto, you may be overwriting the web edits.
We recommend that you establish a clear policy about how this published page will be revised.

Are you sure you want to continue? (y/n) › No

ERROR: Error
    at verifyOrWarnManagePermissions (file:///Users/wickhamc/Documents/posit/quarto-cli/src/publish/confluence/confluence-verify.ts:82:13)
    at async Object.publish (file:///Users/wickhamc/Documents/posit/quarto-cli/src/publish/confluence/confluence.ts:263:3)
    at async publishSite (file:///Users/wickhamc/Documents/posit/quarto-cli/src/publish/publish.ts:114:36)
    at async publish (file:///Users/wickhamc/Documents/posit/quarto-cli/src/command/publish/cmd.ts:276:9)
    at async doPublish (file:///Users/wickhamc/Documents/posit/quarto-cli/src/command/publish/cmd.ts:196:7)
    at async publishAction (file:///Users/wickhamc/Documents/posit/quarto-cli/src/command/publish/cmd.ts:259:7)
    at async Command.fn (file:///Users/wickhamc/Documents/posit/quarto-cli/src/command/publish/cmd.ts:154:11)
    at async Command.execute (file:///Users/wickhamc/Documents/posit/quarto-cli/src/vendor/deno.land/x/cliffy@v0.25.4/command/command.ts:1790:7)
    at async quarto (file:///Users/wickhamc/Documents/posit/quarto-cli/src/quarto.ts:119:3)
    at async file:///Users/wickhamc/Documents/posit/quarto-cli/src/quarto.ts:151:5
> quarto check

[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.1.1: OK
      Dart Sass version 1.55.0: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 99.9.9
      Path: /Users/wickhamc/Documents/posit/quarto-cli/package/dist/bin

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.11.2
      Path: /usr/local/bin/python3
      Jupyter: 5.2.0
      Kernels: python3

(\) Checking Jupyter engine render....0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
[✓] Checking Jupyter engine render....OK

[✓] Checking R installation...........OK
      Version: 4.2.2
      Path: /Library/Frameworks/R.framework/Resources
      LibPaths:
        - /Users/wickhamc/R/4.2
        - /Library/Frameworks/R.framework/Versions/4.2-arm64/Resources/library
      knitr: 1.40
      rmarkdown: 2.16

[✓] Checking Knitr engine render......OK
Checklist
  • Please include a minimal, fully reproducible example in a single .qmd file? Please provide the whole file rather than the snippet you believe is causing the issue.
  • Please format your issue so it is easier for us to read the bug report.
  • Please document the RStudio IDE version you're running (if applicable), by providing the value displayed in the "About RStudio" main menu dialog?
  • Please document the operating system you're running. If on Linux, please provide the specific distribution.
  • Please provide the output of quarto check so we know which version of quarto and its dependencies you're running.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/publish/confluence/confluence-verify.ts at verifyOrWarnManagePermissions, then trace its call from src/publish/confluence/confluence.ts. Reproduce with quarto create project confluence, publish to a public space, and answer No to the permissions warning. Done means cancellation produces a clear user message and exits without an Error; no test file is mentioned.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.