quarto-dev / quarto-dev/quarto-cli
Chores: Clean usage of `Deno.build.os` for Windows to reduce duplication
Open
@cderv is already working on this.
Since Mar 7, 2023.
deno
enhancement
- Dominant language
- JavaScript
- Stars
- 6k
- Forks
- 458
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 41
Description
We are using a lot Deno.build.os === "windows" though we have cleaner solution for our code.
We have our own wrapper
https://github.com/quarto-dev/quarto-cli/blob/20e627913e1f4ebd4df9ad8d8140c40b08752824/src/core/platform.ts#L12-L14
and there is one also in https://deno.land/std@0.166.0/_util/os.ts
I believe this would be beneficial for our code to be simpler with less duplication
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.