quarto-dev / quarto-dev/quarto-cli

publish: don't load entire file into memory to compute hash

Open
#4,513 0 comments 0 reactions 1 assignee View on GitHub

@cscheid is already working on this.

Since Feb 23, 2023.

enhancement publishing
Dominant language
JavaScript
Stars
6k
Forks
458
Avg merge
1d 9h
Merged PRs (30d)
41

Description

in src/publish/common/publish.ts, we currently use the full-buffer version of the crypto API, which requires loading the whole file into memory. We've had user trouble in the past with this and large files (understandably).

TIL that Deno has an extension of the web crypto api through their standard library that provides AsyncIterable support for digest()

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.