quarto-dev / quarto-dev/quarto-cli

v2 Google Fonts API?

Open
#22 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bootstrap enhancement third-party
Dominant language
JavaScript
Stars
6k
Forks
458
Avg merge
1d 9h
Merged PRs (30d)
41

Description

It looks like the embedded bootswatch themes currently use the v1 Google Fonts API that doesn't support variable fonts:

https://github.com/quarto-dev/quarto-cli/blob/a14f4b3090178f8e01f17e28a9e93d3f5b269065/src/resources/formats/html/bootstrap/themes/sketchy.scss#L169

It doesn't seem to impact behavior of themes now, but something to be aware of is the v2 Google Fonts API uses a different base URL, see:
https://developers.google.com/fonts/docs/css2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the linked src/resources/formats/html/bootstrap/themes/sketchy.scss location and review the embedded Google Fonts URL. Compare the current endpoint with the Google Fonts CSS2 documentation, then check the other embedded themes for the same API usage. Done means applicable theme URLs use the intended API and the themes continue to load their fonts.

Written by the indexing model from the issue text.

Assessment

Tech stack
scss
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.