quarto-dev / quarto-dev/quarto-cli

a11y: listing pagination aria-label is not localizable

Open Beginner friendly
#14,810 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

accessibility bug listings
Dominant language
JavaScript
Stars
6k
Forks
458
Avg merge
1d 9h
Merged PRs (30d)
41

Description

The listing pagination nav has an aria-label, but it is hardcoded English: aria-label="Page Navigation" (_pagination.ejs.md#L4). On a non-English site the label stays English. The same template already uses the localization helper two lines above (_pagination.ejs.md#L2, listing.utilities.localizedString("listing-page-no-matches")), so a language key is a drop-in fix.

Suggested fix: add a listing-pagination-label language key and use it via listing.utilities.localizedString. A default of "Pagination" also avoids a label collision with the prev/next page navigation ("Page navigation"), which appears on the same page when a site sets page-navigation: true (see #14376).

Split from #14376. Part of #8706.

Investigation was AI-assisted, grounded in a local clone (per CONTRIBUTING.md).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/resources/projects/website/listing/_pagination.ejs.md and compare the hardcoded aria-label with the existing listing.utilities.localizedString call. Inspect the localization entries for where listing-pagination-label belongs. Done when the pagination label uses that key with a default of "Pagination" and remains distinct from page navigation.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
accessibility, localization
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
86/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.