quarto-dev / quarto-dev/quarto-cli
Nicer return for quarto call engine julia status when no server is up (instead of error)
Open
Nobody has claimed this yet.
engines-julia
enhancement
- Dominant language
- JavaScript
- Stars
- 6k
- Forks
- 458
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 41
Description
This is what I get when no server is running
❯ quarto call engine julia status
ERROR: ConnectionRefused: Aucune connexion n’a pu être établie car l’ordinateur cible l’a expressément refusée. (os error 10061)
Stack trace:
at async Object.connect (ext:deno_net/01_net.js:640:11)
at async getReadyServerConnection (file:///C:/Users/chris/scoop/apps/quarto-prerelease/current/bin/quarto.js:78051:16)
at async _Command.logStatus [as actionHandler] (file:///C:/Users/chris/scoop/apps/quarto-prerelease/current/bin/quarto.js:78366:16)
at async _Command.execute (file:///C:/Users/chris/scoop/apps/quarto-prerelease/current/bin/quarto.js:9833:7)
at async _Command.parseCommand (file:///C:/Users/chris/scoop/apps/quarto-prerelease/current/bin/quarto.js:9710:14)
at async quarto (file:///C:/Users/chris/scoop/apps/quarto-prerelease/current/bin/quarto.js:170932:5)
at async file:///C:/Users/chris/scoop/apps/quarto-prerelease/current/bin/quarto.js:170960:5
at async file:///C:/Users/chris/scoop/apps/quarto-prerelease/current/bin/quarto.js:170815:14
at async mainRunner (file:///C:/Users/chris/scoop/apps/quarto-prerelease/current/bin/quarto.js:170817:5)
at async file:///C:/Users/chris/scoop/apps/quarto-prerelease/current/bin/quarto.js:170953:3
I am thinking that status should return some nicer outputs instead of an error. I used this command to check that the server was indeed closed.
cc @jkrumbiegel what do you think ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the logStatus and getReadyServerConnection paths shown in the quarto.js stack trace for quarto call engine julia status. Determine how the command handles a refused connection, then make the no-server case produce a clearer status result instead of the displayed error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100