Wrong alignment for table/figure in `docx` (`fig-ali... | quarto-dev/quarto-cli

Alignment is hardcoded by Quarto (not using reference style)

https://github.com/quarto-dev/quarto-cli/blob/39baf4081f184fe090974295b48d1beab32cd1e4/src/resources/filters/layout/docx.lua#L97-L110

In theory, fig-align is supposed to control caption but it's not the case (maybe related to the cross-reference system refactoring/improvement)

Input Output

Input	Output
`--- title: "Quarto Playground" format: docx: reference-doc: centre-caption.docx fig-align: center --- ![An image 1]({{< placeholder 600 400 >}}){#fig-placeholder-1} ![An image 2]({{< placeholder 600 400 >}}){#fig-placeholder-2 fig-align="right"}`

---
title: "Quarto Playground"
format:
  docx:
    reference-doc: centre-caption.docx
    fig-align: center
---

![An image 1]({{< placeholder 600 400 >}}){#fig-placeholder-1}

![An image 2]({{< placeholder 600 400 >}}){#fig-placeholder-2 fig-align="right"}

Now, if I remove the alignment hardcoded/added, in addition to get fig-align working, you also get the reference document works by default as one might expect.

function docxParaStyles(align)
  local styles = "<w:pPr>\n"
- local captionAlign = docxAlign(align)
- if captionAlign then
-   styles = styles .. 
-       "<w:jc w:val=\"" .. captionAlign .. "\"/>\n"
- end  
  styles = styles ..
    "<w:spacing w:before=\"200\" />\n" ..
    "<w:pStyle w:val=\"ImageCaption\" />\n" ..
    "</w:pPr>\n"
  return styles
end

Input Output

Input	Output
`--- title: "Quarto Playground" format: docx: reference-doc: centre-caption.docx fig-align: center --- ![An image 1]({{< placeholder 600 400 >}}){#fig-placeholder-1} ![An image 2]({{< placeholder 600 400 >}}){#fig-placeholder-2 fig-align="right"}`
`--- title: "Quarto Playground" format: docx: reference-doc: centre-caption.docx --- ![An image 1]({{< placeholder 600 400 >}}){#fig-placeholder-1} ![An image 2]({{< placeholder 600 400 >}}){#fig-placeholder-2 fig-align="right"}`

---
title: "Quarto Playground"
format:
  docx:
    reference-doc: centre-caption.docx
    fig-align: center
---

![An image 1]({{< placeholder 600 400 >}}){#fig-placeholder-1}

![An image 2]({{< placeholder 600 400 >}}){#fig-placeholder-2 fig-align="right"}

---
title: "Quarto Playground"
format:
  docx:
    reference-doc: centre-caption.docx
---

![An image 1]({{< placeholder 600 400 >}}){#fig-placeholder-1}

![An image 2]({{< placeholder 600 400 >}}){#fig-placeholder-2 fig-align="right"}

Unfortunately, the code which adds the alignment is needed for table caption to be aligned according to the document level tbl-align.

For short, the current implementation is in conflict with itself resulting in more bad results than good.

Quarto document

---
title: "Quarto Playground"
format:
  docx:
    reference-doc: centre-caption.docx
    tbl-align: left
---

![An image 1]({{< placeholder 600 400 >}}){#fig-placeholder-1}

| A | B | C |
|---|---|---|
| 1 | 2 | 3 |
| 4 | 5 | 6 |

: A table 1 {#tbl-table-1}

![An image 2]({{< placeholder 600 400 >}}){#fig-placeholder-2 fig-align="right"}

| A | B | C |
|---|---|---|
| 1 | 2 | 3 |
| 4 | 5 | 6 |

: A table 2 {#tbl-table-2 tbl-align="right"}

Version	Output
v1.7		"Figure 1" should be centred "Figure 2" should be right-aligned "Table 1" is correctly left-aligned "Table 2" should be right-aligned Results: 1 correct out of 4 cases
No alignment added in `docxDivCaption`		"Figure 1" is correctly centred "Figure 2" is correctly right-aligned "Table 1" should be left-aligned "Table 2" is correctly right-aligned Results: 3 correct out of 4 cases

Version

Output

v1.7

"Figure 1" should be centred
"Figure 2" should be right-aligned
"Table 1" is correctly left-aligned
"Table 2" should be right-aligned

Results: 1 correct out of 4 cases

No alignment added in `docxDivCaption`

"Figure 1" is correctly centred
"Figure 2" is correctly right-aligned
"Table 1" should be left-aligned
"Table 2" is correctly right-aligned

Results: 3 correct out of 4 cases

Originally posted by @mcanouil in https://github.com/quarto-dev/quarto-cli/discussions/11513#discussioncomment-11428572

Wrong alignment for table/figure in `docx` (`fig-align` not working)

Description

Contributor guide

First steps

Assessment

Wrong alignment for table/figure in `docx` (`fig-align` not working)

Description

Contributor guide

First steps

Assessment

Get new issues in your inbox