site_libs dependency not updated when freeze is used.

Open
#10,391 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
build-system

Research direction

Start by reproducing the issue with quarto render and freeze: true in the quarto-web example, comparing _site/site_libs/revealjs/dist/reveal.js with _freeze/site_libs/revealjs/dist/reveal.js. Trace how frozen site_libs are selected and determine what should make the frozen dependency update from reveal.js 4.3.1 to 5.1.0; done means rendering no longer restores the old version.

Written by the indexing model from the issue text.

Description

bug early-in-release needs-discussion websites

Observed behavior

I was testing revealjs/update-v5 branch in dev quarto-cli to render our demo slides at https://quarto.org/docs/presentations/revealjs/demo/

This new branch is using revealjs 5.1.0 and I would have expected this to be used.

cd quarto-web
# doing incremental render 
quarto render .\docs\presentations\revealjs\demo\index.qmd

Dependency in site_libs was updated

❯ grep -2 "revealjs[.]com" .\_site\site_libs\revealjs\dist\reveal.js
/*!
* reveal.js 5.1.0
* https://revealjs.com
* MIT licensed
*

But freezer is still using old version

❯ grep -2 "revealjs[.]com" .\_freeze\site_libs\revealjs\dist\reveal.js
/*!
* reveal.js 4.3.1
* https://revealjs.com
* MIT licensed
*

which implies that with freeze: true in our quarto-web project when doing

quarto render

the freezer is used for site_libs it seems, and the old revealjs is used... After quarto render I get

❯ grep -2 "revealjs[.]com" .\_site\site_libs\revealjs\dist\reveal.js
/*!
* reveal.js 4.3.1
* https://revealjs.com
* MIT licensed
*

back to old one.

If I delete the file, then the new version is put in freezer.

So I believe this is a conflict similar to our "different themes in websites", but when using freeze. All the revealjs presentation in the website are using same file in site_libs/.

It seems site_libs in the freezer will always win. So it needs to be updated somehow.

I need to understand this, and see what is the recommended way : Manuel invalidation or a fix in our site_libs handling...

Dominant language
JavaScript
Stars
6k
Forks
458
Avg merge
1d 9h
Merged PRs (30d)
41

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from quarto-dev/quarto-cli

All issues in quarto-dev/quarto-cli

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.