quarto-dev / quarto-dev/quarto-cli

Allow for footer items which contain all three of `text`, `icon`, and `href` subkeys (nav-style)

Open
#10,306 0 comments 0 reactions 1 assignee View on GitHub

@cscheid is already working on this.

Since Jul 16, 2024.

enhancement websites
Dominant language
JavaScript
Stars
6k
Forks
458
Avg merge
1d 9h
Merged PRs (30d)
41

Description

Discussed in https://github.com/quarto-dev/quarto-cli/discussions/10288

Originally posted by connortwiegand July 13, 2024

Description

Hi,

In navbars and sidebar contents, you can pass an item of the form

- icon: foo
  text: bar 
  href: baz.biz

It would be nice if this was supported in the footer as well. Currently, the page-footer key under website allows for

- icon: foo
  href: baz.biz

or

- text: foo
  href: baz.biz

But not all three. A current workaround is to use, e.g.,

- text: "{{< fa rss >}} Feed"
  href: "index.xml"

I think that unification to the text/icon/href schema would be clear + useful, if it's not too much trouble to implement.

Thank you!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.