quarto-dev / quarto-dev/quarto-cli

Shortcode resolution does not work for title in head block when custom partial is set

Open
#10,208 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug projects shortcodes
Dominant language
JavaScript
Stars
6k
Forks
458
Avg merge
1d 9h
Merged PRs (30d)
41

Description

We had changed the template in a few ways and the typescript code wasn't updated

Just for cross-reference, this is where the change in template was discussed.

it looks like we don't allow users to change the metadata.html partial, so this isn't a problem.

Which partials are we talking about ? AFAIK metadata.html can be modified by user, by providing a file with same filename and setting

format:
  html:
    template-partials:
      - metadata.html

If I try this quickly based on this issue example, I can reproduce the shortcode expansion issue. So I think it is still a problem to fix at some point.

Originally posted by @cderv in https://github.com/quarto-dev/quarto-cli/issues/8987#issuecomment-2187248681

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing shortcode expansion for the custom metadata.html partial configured through format.html.template-partials, especially where the title in the head block is resolved. Compare the TypeScript handling with the template change discussed in issues 8904 and 8987. Done means shortcodes in that title resolve correctly when users provide a custom metadata.html partial.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
content
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.