quarkusio / quarkusio/quarkus-github-bot
`buildNumber` is not propagated in dev mode
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 30
- Forks
- 30
- PR merge metrics
- No merged PRs in 30d
Description
buildNumber is not propagated in dev mode and DEV UI shows app version as null in the top right corner of http://localhost:8080/q/dev-ui/ and in http://localhost:8080/q/dev-ui/welcome
This behaviour is caused by https://github.com/quarkusio/quarkus-github-bot/pull/231 changes which sets the version based on the hash, buildNumber property is set to null in dev mode:
Hash works fine when running app in JVM production mode, here is the message from dev mode vs. production jvm mode:
2024-06-19 14:23:01,533 INFO [io.quarkus] (Quarkus Main Thread) quarkus-bot on JVM (powered by Quarkus 3.11.2) started in 1.267s. Listening on: http://localhost:8080
vs.
2024-06-19 14:30:02,608 INFO [io.quarkus] (main) quarkus-bot 77f2357 on JVM (powered by Quarkus 3.11.2) started in 0.499s. Listening on: http://0.0.0.0:8080
I tried to propagate revision property same way as in https://github.com/quarkusio/quarkus-github-bot/commit/88d76b2b5a38be56981922403967a73a73ff5705 and expected value was visible in configuration editor.
Seems this all goes to buildnumber-maven-plugin and how it sets the buildNumber property. @gastaldi any tips on this?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the dev-mode and JVM production startup messages and inspect the buildnumber-maven-plugin handling of buildNumber and revision, including the changes from pull request 231 and commit 88d76b2b5a38be56981922403967a73a73ff5705. Done means the dev UI at /q/dev-ui/ and /q/dev-ui/welcome displays the application version instead of null while production behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system, developer-experience
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100