quarkiverse / quarkiverse/quarkus-github-app

Add support for manual firing of events

Open
#613 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
76
Forks
34
Avg merge
6d 10h
Merged PRs (30d)
4

Description

Hi,

We currently seek a way to fire events manually. We plan to deploy our application behind a VPN, where a webhook from GitHub would not be possible, due to security reasons (I know, this is not how this extensions was meant to be used). We are looking for scheduled polling of events from GitHub's API and then manually firing such events.

I do have a working PR in our repository for this. I was interested, what do you think about it. I have created also a similar testing framework to yours for that, where I tried to reused yours as much as possible (please see this. And usage can be seen here

I expect there would be possibility from this extension to create proxy for GitHubEventEmitter interface, where void fire() would instead be List<GitHubEvent> fire(GitHub github).

However, I understand this is somewhat different use-case from what this app is supposed to serve. Perhaps you could at least expose some functionality we are retrieving with reflection, which is not the best, to remove this class. Also it would be beneficial, if we could allow to serialize mocked GHRepository, such as this is causing exceptions by Mockito. This should be allowed by this setting

Let me know, what you think of this, if that makes sense or not 😊

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the GitHubEventEmitter interface and the linked pull request, especially the reflection-based class and the usage example. Determine whether manually polling and firing GitHub events fits the extension's design, including the proposed fire(GitHub github) API and serializable GHRepository mocks. Done criteria are not defined in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, java
Domain
api, backend-api-design
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.