qualcomm / qualcomm/eld

Use New RISC-V Vendor Relocation Macros

Open
#173 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
259
Forks
84
Avg merge
2d 14h
Merged PRs (30d)
72

Description

https://github.com/qualcomm/eld/pull/171 is a quick build fix today, to solve a problem caused by ANDES adding llvm support for their vendor relocations in https://github.com/llvm/llvm-project/pull/137748

Longer term, I have two PRs to fix this, by restructuring the vendor relocation macros to make them per-vendor:

These two will need to be landed together.

What we do downstream is a bit more complex, as it has been for this kind of ELD/LLVM related change. We probably just need to priority merge the llvm commit as soon as possible.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked LLVM PR 138226 and ELD PR 70 together, then compare them with the quick build fix in ELD PR 171. The issue’s stated completion condition is coordinated landing of the LLVM and ELD changes; downstream handling and priority merging are also called out.

Written by the indexing model from the issue text.

Assessment

Domain
compilers, embedded-iot
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.