qualcomm / qualcomm/eld

Resolve FIXMEs: code duplication and code motion

Open
#1,502 0 comments 0 reactions 1 assignee View on GitHub

@BhoumikPatidar is already working on this.

Since Aug 12, 2026.

refactor
Dominant language
C++
Stars
259
Forks
84
Avg merge
2d 14h
Merged PRs (30d)
72

Description

Bounded refactors, should be NFC.

  • lib/Script/InputSectDesc.cpp:136 — "Remove this code duplication."
  • lib/Script/InputSectDesc.cpp:184 — "Remove this code duplication."
  • lib/Fragment/FragmentRef.cpp:52 — "lots of unnecessary code duplication here"
  • lib/LayoutMap/TextLayoutPrinter.cpp:843 — "Lots of unnecessary code duplication with this function and..."
  • lib/Target/CreateProgramHeaders.hpp:575 — "de-duplicate this case."
  • lib/Target/CreateScriptProgramHeaders.hpp:7 — "remove the common parts and make them private functions."
  • lib/LinkerWrapper/RISCVLinkDriver.cpp:291 — "remove duplicate code"
  • lib/LinkerWrapper/HexagonLinkDriver.cpp:150 — "Refactor this code to a common-place."
  • lib/Target/AArch64/AArch64ErrataIslandFactory.cpp:195 — "insert all trampolines and do this only once per iteration."
  • lib/Object/RuleContainer.cpp:43 — "use an overloaded assignment operator of InputSectDesc::Spec"
  • include/eld/Readers/ELFReader.h:158 / lib/Readers/ELFReaderBase.cpp:232 — "Move ELFRelocObjParser::readSections to RelocELFReader::readSections"
  • lib/Target/RISCV/RISCVRelocator.cpp:956 — "should be moved to the separate relaxation/transformation pass."

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.