qnikst / qnikst/HaskellNet

Check if we need to remove retries in tryCommand

Open
#77 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature help needed
Dominant language
Haskell
Stars
92
Forks
57
PR merge metrics
No merged PRs in 30d

Description

We retry each command several times. Such code always look very suspicious and it seems as it hides potential
problems. I've tried to follow the reasons for adding that, but it was a part of a big commit:

https://github.com/qnikst/HaskellNet/commit/024f647ba67165cc4dee8ec54edeadd992d8cb25

So currently I'm in doubts: removing it will make code cleaner but it could be possible that some systems depend on it and may fail.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating tryCommand and reviewing commit 024f647ba67165cc4dee8ec54edeadd992d8cb25 to understand why retries were introduced. Check whether removing them affects supported POP3, SMTP, or IMAP behavior and define the compatibility evidence or tests needed before deciding. Done means the retry behavior has a documented, justified outcome.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
networking
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.