qdrant / qdrant/vector-db-benchmark
weaviate 1.29: tool should ignore properties that are reserved property names
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 371
- Forks
- 155
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 4
Description
Steps to reproduce:
run weaviate OSS image
docker run -p 8080:8080 -p 50051:50051 cr.weaviate.io/semitechnologies/weaviate:1.29.1
run benchmark
python3 run.py --engines weaviate-m-* --datasets arxiv-titles-384-angular-filters --host <host>
Snippet of issue:
│ /home/ubuntu/.local/lib/python3.10/site-packages/weaviate/connect/v4.py:444 in __send │
│ │
│ 441 │ │ │ ) │
│ 442 │ │ │ res = self._client.send(req) │
│ 443 │ │ │ if status_codes is not None and res.status_code not in status_codes.ok: │
│ ❱ 444 │ │ │ │ raise UnexpectedStatusCodeError(error_msg, response=res) │
│ 445 │ │ │ return cast(Response, res) │
│ 446 │ │ except RuntimeError as e: │
│ 447 │ │ │ raise WeaviateClosedClientError() from e │
│ │
│ ╭─────────────────────────────────────────── locals ───────────────────────────────────────────╮ │
│ │ error_msg = 'Collection may not have been created properly.' │ │
│ │ method = 'POST' │ │
│ │ params = None │ │
│ │ req = <Request('POST', 'http://10.3.0.98:8080/v1/schema')> │ │
│ │ res = <Response [422 Unprocessable Entity]> │ │
│ │ self = <weaviate.connect.v4.ConnectionV4 object at 0x7b474d69aa10> │ │
│ │ status_codes = _ExpectedStatusCodes(ok_in=200, error='Create collection', ok=[200]) │ │
│ │ url = 'http://10.3.0.98:8080/v1/schema' │ │
│ │ weaviate_object = { │ │
│ │ │ 'class': 'Benchmark', │ │
│ │ │ 'vectorizer': 'none', │ │
│ │ │ 'properties': [ │ │
│ │ │ │ { │ │
│ │ │ │ │ 'name': 'update_date_ts', │ │
│ │ │ │ │ 'dataType': ['int'], │ │
│ │ │ │ │ 'indexInverted': True │ │
│ │ │ │ }, │ │
│ │ │ │ { │ │
│ │ │ │ │ 'name': 'labels', │ │
│ │ │ │ │ 'dataType': ['string'], │ │
│ │ │ │ │ 'indexInverted': True │ │
│ │ │ │ }, │ │
│ │ │ │ { │ │
│ │ │ │ │ 'name': 'submitter', │ │
│ │ │ │ │ 'dataType': ['string'], │ │
│ │ │ │ │ 'indexInverted': True │ │
│ │ │ │ }, │ │
│ │ │ │ { │ │
│ │ │ │ │ 'name': 'id', │ │
│ │ │ │ │ 'dataType': ['string'], │ │
│ │ │ │ │ 'indexInverted': True │ │
│ │ │ │ } │ │
│ │ │ ], │ │
│ │ │ 'vectorIndexConfig': { │ │
│ │ │ │ 'vectorCacheMaxObjects': 1000000000, │ │
│ │ │ │ 'distance': 'cosine', │ │
│ │ │ │ 'efConstruction': 128, │ │
│ │ │ │ 'maxConnections': 16 │ │
│ │ │ } │ │
│ │ } │ │
│ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
UnexpectedStatusCodeError: Collection may not have been created properly.! Unexpected status code: 422, with response body: {'error': [{'message': "'id' is a reserved property name"}]}.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure with the Weaviate 1.29.1 Docker image and the run.py benchmark command. Then trace how the benchmark builds the collection properties, including the id field. Done means reserved property names are ignored and the benchmark can create the collection successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python
- Domain
- databases, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100