qdrant / qdrant/vector-db-benchmark

Breaking change in `weaviate-client`

Open
#199 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
371
Forks
155
Avg merge
1d 22h
Merged PRs (30d)
4

Description

The dependency weaviate-client got an (for us) breaking change:

A refactoring of the underlying implementation of the WeaviateClient to use the WeaviateAsyncClient under-the-hood scheduling the necessary coroutines to run in a side-car event-loop thread

(see https://weaviate-python-client.readthedocs.io/en/stable/changelog.html#version-4-7-0)

The event-loop thread (Singleton) in WeaviateClient prevents parallel upload > 1 from working. Because only one instance of the .connect() class is allowed at any one time.

See https://github.com/weaviate/weaviate-python-client/pull/1007

So for a hotfix i will prepare a new version constraint for weaviate-client.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the project's dependency declaration for weaviate-client, then read the linked Weaviate client changelog and upstream PR #1007 for the breaking change. Done means the dependency constraint avoids the incompatible version and parallel uploads can work as expected; the issue does not name a test or exact target version.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.