Clarification on TODO intent

Context

I’m contributing in the REST conversion layer and wanted to clarify the intent of this TODO:

impl From<VectorStructInternal> for VectorStructOutput {
    fn from(value: VectorStructInternal) -> Self {
        // ToDo: this conversion should be removed
        match value {
            VectorStructInternal::Single(vector) => VectorStructOutput::Single(vector),
            VectorStructInternal::MultiDense(vector) => {
                VectorStructOutput::MultiDense(vector.into_multi_vectors())
            }
            VectorStructInternal::Named(vectors) => VectorStructOutput::Named(
                vectors
                    .into_iter()
                    .map(|(k, v)| (k, VectorOutput::from(v)))
                    .collect(),
            ),
        }
    }
}

The TODO says: “this conversion should be removed”.

The conversion in question is the internal-to-REST mapping from VectorStructInternal to VectorStructOutput, used when building REST ScoredPoint responses:

impl From<segment::types::ScoredPoint> for ScoredPoint {
  fn from(value: segment::types::ScoredPoint) -> Self {
    let segment::types::ScoredPoint {
      id,
      version,
      score,
      payload,
      vector,
      shard_key,
      order_value,
    } = value;
    ScoredPoint {
      id,
      version,
      score,
      payload,
      vector: vector.map(VectorStructOutput::from),
      shard_key,
      order_value,
    }
  }
}

#[derive(Serialize, JsonSchema, Clone, Debug)]
pub struct ScoredPoint {
  /// Vector of the point
  #[serde(skip_serializing_if = "Option::is_none")]
  pub vector: Option<VectorStructOutput>,
}

Interpretation options

I see 2 possible interpretations:

1. Helper function approach
   Remove the global From impl and use a local explicit helper, e.g. vector_struct_output_from_internal(...), called only at the REST boundary.

2. Inline mapping approach
   Remove the global From impl and inline the match directly at the call site (no helper function).

Clarification request

Could you confirm which interpretation you intended for that TODO?

Start by locating the From for VectorStructOutput implementation and the REST ScoredPoint conversion shown in the issue. Read the surrounding REST conversion code and tests to determine the intended boundary for this mapping. Done means the TODO's intended refactor is implemented without changing serialized ScoredPoint vector responses.