qdrant / qdrant/qdrant-helm

allow preventing test hooks from being rendered (again)

Open
#246 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
191
Forks
98
Avg merge
2d 4h
Merged PRs (30d)
6

Description

Problem: We are using GCP Cloud Deploy to deploy the chart as a dependency to a GKE cluster. Cloud Deploy calls skaffold render, which, in our case, uses Helm to render the manifest. The rendered manifest then gets applied, including the test-db-interaction deployment. Although the test runs successfully and is marked as completed/successful, Cloud Deploy still marks the release as failed since the test pod is not marked as ready.

Potential Suggested Solution: Introduce a conditional render around the test deployment.

Why did I create a new issue? This is essentially the same request as described in issue #77 . That issue was marked as resolved because the test passed, and the deployment tool no longer flagged the release as failed. However, the underlying problem of preventing the test deployment from being rendered still persists.

I'm happy to create a PR for the suggested solution myself—just wanted to confirm that this mechanism would be an acceptable approach before proceeding.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the Helm templates that define the test-db-interaction deployment and start with the chart render path used by skaffold render. Confirm that a conditional option can omit this deployment from the rendered manifest while preserving the existing test behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
gcp, helm, kubernetes
Domain
cloud, devops, infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.