Review validation of src/href
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
Currently the code rejects links that .startswith("javascript:"). This is blacklisting. Blacklisting is bad.
We'll want to whitelist only things like http://, https://, and data:// with specific mimetypes.
Consider: <a href="javaScript:alert('gotcha')">click here</a>.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the project for validation of src/href and the existing startswith("javascript:") check; begin by reading that entry point and any nearby tests. Done means the validation accepts only the intended http://, https://, and data:// cases with specific mimetypes, including correct handling of mixed-case javascript: links.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100