pytroll / pytroll/pyresample

Add check or force Boundary lons/lats to be 1D

Open
#333 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue hacktoberfest help wanted
Dominant language
Python
Stars
385
Forks
102
Avg merge
4d 2h
Merged PRs (30d)
9

Description

Code Sample, a minimal, complete, and verifiable piece of code
from pyresample.boundary import Boundary
b = Boundary(my_lons, my_lats)
print(b.contour_poly.area())
Problem description

The above code doesn't fail if the provided lons/lats are 2D (not sure on 3D+), but the class and all functions/utilities underneath it assume 1D arrays. The end results are incorrect because of this.

Expected Output

Either an exception or a .ravel() on the provided lons/lats so the rest of the calculations work fine.

Actual Result, Traceback if applicable

Incorrect area and other operations.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Python Boundary class used by the example and inspect how its lons and lats are consumed by contour_poly.area(). Decide whether multidimensional inputs should be rejected or flattened, then verify that the area and related operations no longer silently produce incorrect results.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.