pytroll / pytroll/pyresample

Better PROJ.4 string equality checks

Open
#124 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
385
Forks
102
Avg merge
4d 2h
Merged PRs (30d)
9

Description

Problem description

This was brought up in the changes in my most recent PR (#123). Right now to compare PROJ.4 strings we sort the parameters by keys then compare the result. This is good enough since PROJ.4 has a lot of defaults and different ways that a ellipsoid can be defined. We could try using something like https://github.com/jswhit/pyproj/issues/15#issuecomment-208862786, but it would require gdal in pyresample which isn't great.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search pyresample for the current PROJ.4 string equality implementation that sorts parameters by key, then review the discussion in issue #123 and the linked pyproj comment. Define how equivalent PROJ.4 strings should compare while avoiding a GDAL dependency; done means the behavior is specified and covered by relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.