Cleanup IN_FBCODE logic
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 17.9k
- Forks
- 7.3k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 13
Description
https://github.com/pytorch/vision/pull/8647 introduced a new way of determining whether the code is running internally. We should remove the existing
to avoid any confusion. (That one is only used in tests).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/common_utils.py around line 29 and review PR 8647 to understand the replacement for internal-environment detection. Check how the existing IN_FBCODE logic is used in the test utilities, remove the obsolete logic, and run the affected test suite to confirm tests still work without it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100