Align query_chw and get_dimensions
Open
Nobody has claimed this yet.
enhancement
module: transforms
- Dominant language
- Python
- Stars
- 17.9k
- Forks
- 7.3k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 13
Description
We have to proper combination
However, we have the combination below that diverges on the name
I don't recall anymore how we ended up with this, but we should correct it.
My vote is out for also calling it query_dimensions since we already have
in v1.
cc @vfdev-5
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare query_chw and get_dimensions in torchvision/transforms/v2/functional/_meta.py and torchvision/transforms/v2/utils.py at the referenced lines, then review torchvision/transforms/functional.py for the v1 query_dimensions naming. Align the divergent helper name and update its uses so the v2 naming is consistent with the intended convention.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-vision
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100