Inconsistent representation of box in torchvision.ops
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 17.9k
- Forks
- 7.3k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 13
Description
Feature suggestion
When checking the how the new operations in the torchvision 0.11 work, I found an inconsistency between different function.
import torchvision.ops as tops
import torch
import torch.nn as nn
a = torch.zeros(1, 1, 8, 8)
a[..., :4, 4:] = 1
bbox = tops.masks_to_boxes((a==1)[0].float())
area = tops.box_area(bbox) # the returned area is 9 which should be 16
new_box = tops.box_convert(bbox, 'xyxy', 'xywh') # which returns [4, 4, 3, 3] => expected output [4, 4, 4, 4]
Suggest a potential alternative/fix
This is not actually an error but could cause confusion.
I suggest to make the box representations between different function more consistent.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the supplied example and inspect the torchvision.ops entry points masks_to_boxes, box_area, and box_convert. Compare their box-coordinate conventions and related documentation or tests; done means the representation is consistent across these operations and the example has a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100