pytorch / pytorch/vision

test_write_video_with_audio is disabled on Windows

Open
#3,078 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

module: io module: tests windows
Dominant language
Python
Stars
17.9k
Forks
7.3k
Avg merge
1d 15h
Merged PRs (30d)
13

Description

With https://github.com/pytorch/vision/pull/2304, I had to disable Windows tests test_write_video_with_audio.
This is a workaround in order to move forward with fbcode sync.

We should re-enable those tests and fix what was wrong with Windows testing.

cc @peterjc123 @nbcsm @guyang3532 @maxluk @gunandrose4u @smartcat2010 @mszhanyi

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the disabled test_write_video_with_audio Windows tests and reviewing the referenced pull request 2304. Reproduce the Windows testing problem, identify why the tests were disabled, and re-enable them once they pass on Windows.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-vision, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.