pytorch / pytorch/vision

Mismatch in build_vision.sh environment variables

Open
#2,867 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

topic: binaries windows
Dominant language
Python
Stars
17.9k
Forks
7.3k
Avg merge
1d 15h
Merged PRs (30d)
13

Description

The if-statement is checking TORCHVISION_BUILD_VERSION but the body uses PYTORCH_BUILD_VERSION. Same issue with BUILD_NUMBER.

https://github.com/pytorch/vision/blob/d1e134c71b94a5975dcbf16927ed608dac54fdfe/packaging/conda/build_vision.sh#L19-L22

cc @peterjc123 @nbcsm @guyang3532 @maxluk @gunandrose4u @smartcat2010 @mszhanyi

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect packaging/conda/build_vision.sh at lines 19-22, starting with the environment-variable checks and the values used in their bodies. Done means the conditionals consistently refer to the intended build-version and build-number variables; no test file is mentioned in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.