Feedback: Saving a DDP-Wrapped Model
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 9.3k
- Forks
- 4.4k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
There is the following issue on this page: https://docs.pytorch.org/tutorials/beginner/saving_loading_models.html
Issue: I am referring to the section https://docs.pytorch.org/tutorials/beginner/saving_loading_models.html#saving-torch-nn-dataparallel-models. Contrary to this other tutorial https://docs.pytorch.org/tutorials/intermediate/ddp_tutorial.html it does not include (in the "save" section) that given a DDP wrapped model DDPmodel one needs to access its .load_state_dict method.
cc @wconstab @osalpekar @H-Huang @kwen2501 @mikaylagawarecki
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the saving/loading models page and its “Saving torch.nn.DataParallel Models” section, then compare the save section of the DDP tutorial. Done when the documentation explains how to access the wrapped model’s load_state_dict method for a DDP-wrapped model.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- distributed-systems, documentation, machine-learning
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100