[Feature Request] TensorSpec is_in methods should check the dtype of val
Open
@vmoens is already working on this.
Since Jan 4, 2023.
enhancement
Good first issue
- Dominant language
- Python
- Stars
- 3.6k
- Forks
- 487
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 207
Description
Motivation
As mentioned in #783, we should check that is_in always checks the dtype.
Solution
Add self.dtype == val.dtype condition in the is_in methods. Should be very simple to fix, but we need to make sure that all tests pass.
Checklist
- I have checked that there is no similar issue in the repo (required)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.