pytorch / pytorch/rl

[Feature Request] Rename `step_tensordict` in `step_mdp`

Open
#503 0 comments 0 reactions 1 assignee View on GitHub

@vmoens is already working on this.

Since Oct 3, 2022.

enhancement
Dominant language
Python
Stars
3.6k
Forks
484
Avg merge
1d 1h
Merged PRs (30d)
207

Description

Motivation

step_tensordict has a non-intuitive name: it points to TensorDict when actually its usage is really to make a step in the MDP.

The appropriate name should be step_mdp.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.