[BUG] sota-implementation requires nightly built
Open
@vmoens is already working on this.
Since Aug 26, 2024.
bug
- Dominant language
- Python
- Stars
- 3.6k
- Forks
- 487
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 207
Description
Describe the bug
dqn_cartpole from sota-implementations/dqn doesn't working. Crashes with: ImportError: cannot import name 'Composite' from 'torchrl.data'
To Reproduce
Just run dqn_cartpole.py, it will call ulits_cartpole.py and then it will crash with ImportError
System info
Describe the characteristic of your environment:
- The library was installed using pip
- Python version = 3.9.19
Reason and Possible fixes
After some time i think rename Composite -> CompositeSpec in importing and in it's only one will fix this issue
Checklist
- I have checked that there is no similar issue in the repo (required)
- I have read the documentation (required)
- I have provided a minimal working example to reproduce the bug (required)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.